Better loading indicator #43
Conversation
A-Guldborg
added
enhancement
There was a problem hiding this comment.
I agree that in the current version, it's not very desirable. My initial thought was that we would wrap MudLoading in our current LoadingIndicator component, so the syntax for using it would be something like :
<LoadingIndicator Loading="_loading" Height ="400px">
<WhatEverChildContent>
</WhatEverChildContent>
</LoadingIndicator >
Doing so would both make the syntax for using it a lot more concise, and avoid unnecessary duplication.
As for the changes in the layout, I'm not sure why they are necessary without sitting a bit with it. If you want to revisit this, either by yourself or with me. Let me know. Otherwise, I can also try to draft something up
We can definitely look at it together, or you can draft something up before "pair-programming", but I think if you include the |
Attempted to fix #39
However, there are two issues:
LoaderContentandChildContent, where the first is what is shown while loading and the latter while not loading. This means that we have to move any input fields outside of ourMudLoadingcomponent if we want to show it all the time (such as input fields, otherwise they will "reload" on input change). I am not a stylist/webdesigner, so this also means some of our pages changes slightly, see screenshots below.MudTablein ourUserTableafter I "pulled" the input field outside theMudTablein order to not have this reload every time we search for something, but after searching for a user it ends up being stuck on the loading icon. Likely, this is because of theServerDatanot working with the input field outside or something along those lines, but I did not have more time to investigate this.I like that we can add the loading content thing "prettier" and an if-statement, but I don't think it saves us any complexity. With the below changes in mind, and the differences in code from the previous versions and this, I suggest we consider whether we want to pursue this further. Consider this a quick proof of concept (even though it does not prove 100%), and feel more than free to scratch it if you don't think it adds the right value.
Changes
Our Statistics page changed from:
To:
Our Manage User page changed from:
To:
(And still does not work)